-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(psl): GA fullTextSearch
for mysql
, introduce nativeFullTextSearchPostgres
for postgres
#5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rename it to "nativeFullTextSearchPostgres" for Postgres
CodSpeed Performance ReportMerging #5055 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
aqrln
reviewed
Nov 26, 2024
aqrln
reviewed
Nov 26, 2024
…ative preview features, add tests
…ve_full_text_search_preview_feature"
jkomyno
force-pushed
the
feat/ga-fullTextSearch
branch
from
November 26, 2024 16:24
cbf597e
to
819f55e
Compare
…eMapWithProvider"
…tureMapWithProvider"
jkomyno
force-pushed
the
feat/ga-fullTextSearch
branch
from
November 26, 2024 20:13
776d2db
to
09dc081
Compare
aqrln
reviewed
Nov 27, 2024
aqrln
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
fullTextIndex
andfullTextSearch
forprovider = "mysql"
#5031fullTextSearch
onmysql
fullTextSearchPostgres
forpostgres
, which replacesfullTextSearch
This is the first time we GA a preview feature for a a subset of every Prisma-supported connector, while also renaming a preview feature for a specific connector:
fullTextSearch
forprovider = "mysql"
, butpsl_core::common::preview_features::FeatureMap
has no knowledge of which Prisma database provider is currently selected by the userfullTextSearch
asnativeFullTextSearchPostgres
forprovider = "postgresql"
onlyHence, I've introduced
psl_core::common::preview_features::FeatureMapWithProvider::<'a>
, which, given aprovider
, exposes the same functionality as the oldFeatureMap
, but allows for escape hatches whenprovider = "mysql"
.FeatureMap
is now a private struct.I've added a default implementation of
FeatureMapWithProvider
as a convenience for https://github.com/prisma/language-tools, which is selected when thedatasource
block doesn't yet have a validprovider
value.The
FeatureMap
struct now has two new fields:native: BTreeMap<&'static str, PreviewFeatures>
, which lists the valid connector-specific features. It's a map from database provider to the set of native preview features.renamed: BTreeMap<RenamedFeatureKey, RenamedFeatureValue>
, which keeps track of the renamed deprecated issues. It's a map from a deprecated preview feature and an optional database provider to the new, active preview feature, along with information useful for diagnostic messages.Both map entries are feature-gated at compile-time. Since
BTreeMap
insertion isn'tconst
-initialisable, I had to move theFeatureMap
instantiation intoFeatureMapWithProvider::new
, while also introducingstd::sync::LazyLock
forALL_PREVIEW_FEATURES
, the defaultFeatureMapWithProvider
value.provider = "mysql"
, writingpreviewFeatures = ["fullTextSearch"]
inschema.prisma
now results in the following validation warning:provider = "postgres"
/provider = "postgresql"
, writingpreviewFeatures = ["fullTextSearch"]
inschema.prisma
now results in the following validation warning:provider = "postgres"
/provider = "postgresql"
, writingpreviewFeatures = ["fullTextSearchPostgres"]
inschema.prisma
is now valid.